He was a prominent film lyricist, Urdu writer, critic and academician. His famous films as lyricist were Choorian (1998), Nikki Jei Haan (1999), Teray Pyar Mein (2000), Mehndi Walay Hath (2000), Rukhtsati (2001) and Shararat (2003), Koi Tujh sa Kahan (2005), Majajan (2006).
He wrote many books, novels and other academic articles.